Use == operator for shared_ptr nullptr comparison #9465
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: From C++ 20 onwards, the != operator is not supported for a shared_ptr. So switch to using ==. Test Plan: make check Reviewers: Subscribers: Tasks: Tags:
riversand963
approved these changes
Jan 28, 2022
|
@anand1976 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Yes, that's a good idea. Internally, Meta is moving to platform-010, so we'll likely run into more such issues. |
anand1976
pushed a commit
that referenced
this pull request
Jan 28, 2022
Summary: From C++ 20 onwards, the != operator is not supported for a shared_ptr. So switch to using ==. Pull Request resolved: #9465 Test Plan: make check Reviewed By: riversand963 Differential Revision: D33850596 Pulled By: anand1976 fbshipit-source-id: eec16d1aa6c39a315ec2d44d233d7518f9c1ddcb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From C++ 20 onwards, the != operator is not supported for a shared_ptr.
So switch to using ==.
Test Plan:
make check