Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around snappy linker issue with newer compilers #9517

Closed

Commits on Feb 7, 2022

  1. Work around snappy linker issue with newer compilers

    Summary: After facebook#9481, we are using newer default compiler for
    build-format-compatible CircleCI nightly job, which fails on building
    2.2.fb.branch branch because it tries to use a pre-compiled libsnappy.a
    that is checked into the repo (!). This works around that by setting
    SNAPPY_LDFLAGS=-lsnappy, which is only understood by such old versions.
    
    Test Plan: Run check_format_compatible.sh on Ubuntu 20 AWS machine,
    watch nightly run
    pdillinger committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    ee894ce View commit details
    Browse the repository at this point in the history