WIP: Sanitize options outside of a DB #9552
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves most of the code associated with sanitizing options from inside the DB into the Options classes. This allows the Options to be sanitized prior to creating the DB.
Additionally, this code allows the sanitization of the Options to fail. If some option cannot be properly reconciled, the Sanitize methods can return an error.
OptionTypeInfo can also define a Sanitize methods that allow them to perform their own check. This is comparable to what is done with Validate and will allow these types to massage the options as appropriate. For example, a PosixFileSystem may need to change values a different way than a Memory or Windows or other may need to.