Support WBWI for keys having timestamps #9603
Conversation
riversand963
changed the title
|
@riversand963 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@riversand963 has updated the pull request. You must reimport the pull request before landing. |
|
@riversand963 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was exported from Phabricator. Differential Revision: D34354849 |
riversand963
force-pushed
the
ts-wbwi
branch
from
e01bc0c
to
a599ef8
Compare
There was a problem hiding this comment.
Thanks for the PR @riversand963 ! LGTM in general, just a few minor comments/questions
| ASSERT_OK(wb1.Put(&cf0, "key", "value")); | ||
| ASSERT_FALSE(WriteBatchInternal::HasKeyWithTimestamp(wb1)); |
There was a problem hiding this comment.
For the sake of completeness, we could consider adding coverage for the timestamp-less Delete and SingleDelete too.
Summary: This PR supports inserting keys to a `WriteBatchWithIndex` for column families that enable user-defined timestamps and reading the keys back. **The index does not have timestamps.** Writing a key to WBWI is unchanged, because the underlying WriteBatch already supports it. When reading the keys back, we need to make sure to distinguish between keys with and without timestamps before comparison. When user calls `GetFromBatchAndDB()`, no timestamp is needed to query the batch, but a timestamp has to be provided to query the db. The assumption is that data in the batch must be newer than data from the db. Pull Request resolved: facebook#9603 Test Plan: make check Differential Revision: D34354849 Pulled By: riversand963 fbshipit-source-id: 8721eb10de5b3abaca7259f8dc6a54785706e35a
riversand963
force-pushed
the
ts-wbwi
branch
from
a599ef8
to
92659f5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D34354849 |
|
Thanks @ltamasi for the review! |
This PR supports inserting keys to a
WriteBatchWithIndexfor column families that enable user-defined timestampsand reading the keys back. The index does not have timestamps.
Writing a key to WBWI is unchanged, because the underlying WriteBatch already supports it.
When reading the keys back, we need to make sure to distinguish between keys with and without timestamps before
comparison.
When user calls
GetFromBatchAndDB(), no timestamp is needed to query the batch, but a timestamp has to beprovided to query the db. The assumption is that data in the batch must be newer than data from the db.
Test plan:
make check