Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Improve build speed #9605

Closed
wants to merge 14 commits into from
Closed

[CI] Improve build speed #9605

wants to merge 14 commits into from

Conversation

jay-zhuang
Copy link
Contributor

@jay-zhuang jay-zhuang commented Feb 19, 2022 •
edited
Loading

Improve the CI build speed:

  • split the macos tests to 2 parallel jobs
  • split tsan tests to 2 parallel jobs
  • move non-shm tests to nightly build
  • slow jobs use lager machine
  • fast jobs use smaller machine
  • add microbench to no-test jobs
  • add run-microbench to nightly build

@facebook-github-bot
Copy link
Contributor

@jay-zhuang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@pdillinger
Copy link
Contributor

I vote for keeping it because it makes sure non-trivial code dependent on our APIs keeps compiling. (I broke it recently and CI caught it.)

It might be more resource efficient to merge it into the 'examples' build or similar.

@riversand963
Copy link
Contributor

+1 for keeping it. At least make sure new code changes do not break it

@facebook-github-bot
Copy link
Contributor

@jay-zhuang has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@jay-zhuang has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@jay-zhuang has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@jay-zhuang has updated the pull request. You must reimport the pull request before landing.

1 similar comment
@facebook-github-bot
Copy link
Contributor

@jay-zhuang has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@jay-zhuang has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@jay-zhuang has updated the pull request. You must reimport the pull request before landing.

@jay-zhuang
Revert "try string"
b6d29b7 
This reverts commit 40fd2d0.
@facebook-github-bot
Copy link
Contributor

@jay-zhuang has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@jay-zhuang has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@jay-zhuang has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@jay-zhuang has updated the pull request. You must reimport the pull request before landing.

@jay-zhuang jay-zhuang changed the title [CI] Remove microbenchmark job [CI] Improve build speed Mar 3, 2022
@jay-zhuang
Copy link
Contributor Author

+1 for keeping it. At least make sure new code changes do not break it

sounds good, I updated it to build microbench in some no-tests builds, as the microbench test result doesn't make sense to us, I moved run-microbench to nightly build. (plus we have the internal tools to run the microbench).

I improved a few other jobs to make it finish faster (the slowest one is windows cxx20 build, ~30 min)

@facebook-github-bot
Copy link
Contributor

@jay-zhuang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

riversand963
riversand963 approved these changes Mar 3, 2022
View reviewed changes
Copy link
Contributor

@riversand963 riversand963 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I see that you have increased instance capacity for a number of jobs, hope it's ok. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riversand963 riversand963 riversand963 approved these changes

@pdillinger pdillinger Awaiting requested review from pdillinger

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jay-zhuang @facebook-github-bot @pdillinger @riversand963