Add support for BlobDB to ldb #9630
Conversation
changneng
force-pushed
the
blob_support_in_ldb
branch
from
8b0b6fa
to
dfba858
Compare
|
@changneng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
There was a problem hiding this comment.
Thanks a lot for the PR @changneng ! Please see some comments below.
|
@changneng has updated the pull request. You must reimport the pull request before landing. |
3 similar comments
|
@changneng has updated the pull request. You must reimport the pull request before landing. |
|
@changneng has updated the pull request. You must reimport the pull request before landing. |
|
@changneng has updated the pull request. You must reimport the pull request before landing. |
changneng
force-pushed
the
blob_support_in_ldb
branch
from
a58b917
to
eab2ba5
Compare
|
@changneng has updated the pull request. You must reimport the pull request before landing. |
|
@changneng has updated the pull request. You must reimport the pull request before landing. |
|
@changneng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
There was a problem hiding this comment.
Thanks for the updates @changneng ! The changes look good in general 👍👍; just some minor comments
|
@changneng One more thing - could you please mention this change in |
|
@changneng has updated the pull request. You must reimport the pull request before landing. |
1 similar comment
|
@changneng has updated the pull request. You must reimport the pull request before landing. |
|
@changneng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
…st cases for BlobDB options in `ldb`
2. Remove `blobParams` in `dump` the test case 3. Validation: `min_blob_size >= 0` instead of `min_blob_size > 0` 4. Use `auto` to define iterator for convenience
changneng
force-pushed
the
blob_support_in_ldb
branch
from
fd7ca43
to
0bd2f33
Compare
|
@changneng has updated the pull request. You must reimport the pull request before landing. |
|
@changneng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@changneng has updated the pull request. You must reimport the pull request before landing. |
|
@changneng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary:
Add the configuration options and help messages of BlobDB to
ldbTest Plan:
python ./tools/ldb_test.py