Reenable s390x platform_dependent travis job #9631
Conversation
|
We should really remove the "status_checked" testing from Travis. It is a code hygiene test that doesn't really need to be run of different platforms, so is obsolete on Travis now that it's well covered in CircleCI. And still seeing with your changes. https://app.travis-ci.com/github/facebook/rocksdb/jobs/561117356 That failure does seem consistent with OOM killer kicking in, but not sure what else we should do about that. |
|
Thanks for the status_checked info @pdillinger, I can add a commit to remove those jobs if ok to do in this PR. About the failure, I hadn't thought of the OOM killer causing it. I'm not sure what to do either other than reducing parallelism to 1, let me look at it some more. It looks like there is only about 4GB free and no swap on s390x. I may have just been lucky with my test builds. |
Yes, please remove it in this PR. Thanks. More justification: we want to minimize unnecessary exposure to random failures and minimize duplicate failures on these platforms. (For example, legit test failures would duplicate as test failures with ASC also.) |
on all platforms and are covered on circle-ci.
failure during compilation.
jonathan-albrecht-ibm
force-pushed
the
s390x-travis-xenial
branch
from
12f9ffc
to
a71cac0
Compare
|
@pdillinger has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Thanks @pdillinger! |
Summary: Fix g++ -march=native detection and reenable s390x in travis This PR fixes s390x assembler messages: ``` Error: invalid switch -march=z14 Error: unrecognized option -march=z14 ``` The s390x travis build was failing with gcc-7 because the assembler on ubuntu 16.04 is too old to recognize the z14 model so it doesn't work with -march=native on a z14 machine. It fixes the check for the -march=native flag so that the assembler will get called and correctly fail on ubuntu 16.04 which will cause the build to fall back to -march=z196 which works. The other changes are needed so builds work more consistently on s390x: 1. Set make parallelism to 1 for s390x: The default was 4 previously but I saw frequent internal compiler errors on travis probably due to low resources. The `platform_dependent` job works more consistently but is roughly 10 minutes slower although it varies. 2. Remove status_checked jobs, as we are relying on CircleCI for these now and do not really need platform coverage on them. Fixes #9524 Pull Request resolved: #9631 Test Plan: CI Reviewed By: ajkr Differential Revision: D34553989 Pulled By: pdillinger fbshipit-source-id: a6e3a7276446721c4c0bebc4ed217c2ca2b53f11
Summary: Fix g++ -march=native detection and reenable s390x in travis
This PR fixes s390x assembler messages:
The s390x travis build was failing with gcc-7 because the assembler on
ubuntu 16.04 is too old to recognize the z14 model so it doesn't work
with -march=native on a z14 machine. It fixes the check for the
-march=native flag so that the assembler will get called and correctly
fail on ubuntu 16.04 which will cause the build to fall back to
-march=z196 which works.
The other changes are needed so builds work more consistently on
s390x:
but I saw frequent internal compiler errors on travis probably due to
low resources. The
platform_dependentjob works more consistentlybut is roughly 10 minutes slower although it varies.
these now and do not really need platform coverage on them.
Fixes #9524
Test Plan: CI