Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic toggling of BlockBasedTableOptions::detect_filter_construct_corruption #9654

Closed
wants to merge 1 commit into from
Closed

Dynamic toggling of BlockBasedTableOptions::detect_filter_construct_corruption #9654

wants to merge 1 commit into from

Conversation

hx235
Copy link
Contributor

@hx235 hx235 commented Mar 3, 2022

Context/Summary:
As requested, BlockBasedTableOptions::detect_filter_construct_corruption can now be dynamically configured using DB::SetOptions after this PR

Test:

  • New unit test

@hx235 hx235 added the WIP Work in progress label Mar 3, 2022
@hx235 hx235 marked this pull request as draft March 3, 2022 19:40
@hx235 hx235 force-pushed the dynamic_detect_filter_construct_corruption branch from d4dfbda to 79446ea Compare March 3, 2022 20:47
@hx235 hx235 force-pushed the dynamic_detect_filter_construct_corruption branch from 79446ea to 161ce5d Compare March 3, 2022 20:47
@facebook-github-bot
Copy link
Contributor

@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@hx235 hx235 requested a review from pdillinger March 3, 2022 21:41
@hx235 hx235 removed the WIP Work in progress label Mar 3, 2022
@hx235 hx235 marked this pull request as ready for review March 3, 2022 21:42
pdillinger
pdillinger approved these changes Mar 3, 2022
View reviewed changes
Copy link
Contributor

@pdillinger pdillinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdillinger pdillinger pdillinger approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hx235 @facebook-github-bot @pdillinger