Test refactoring for Backups+Temperatures #9655
Conversation
Summary: In preparation for more support for file Temperatures in BackupEngine, this change does some test refactoring: * Move DBTest2::BackupFileTemperature test to BackupEngineTest::FileTemperatures, which some updates to make it work in the new home. This test will soon be expanded for deeper backup work. * Move FileTemperatureTestFS from db_test2.cc to db_test_util.h, to support sharing because of above moved test. * Use custom FileSystems in backupable_db_test rather than custom Envs, because going through Env file interfaces doesn't support temperatures. * Fix RemapFileSystem to map DirFsyncOptions::renamed_new_name parameter to FsyncWithDirOptions, which was required because this limitation caused a crash only after moving to higher fidelity of FileSystem interface (vs. LegacyDirectoryWrapper throwing away some parameter details) Test Plan: test code updates only
|
@pdillinger has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@pdillinger has updated the pull request. You must reimport the pull request before landing. |
|
@pdillinger has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
| } | ||
| }; | ||
|
|
||
| TEST_F(DBTest2, BackupFileTemperature) { |
There was a problem hiding this comment.
thanks for the refactor. I think we can also remove the include:
Line 24 in 2b54e52
| logger_options.env = db_chroot_env_.get(); | ||
| // TODO: This should really be an EXPECT_OK, but this CreateLogger fails | ||
| // regularly in some environments with "no such directory" | ||
| CreateLoggerFromOptions(dbname_, logger_options, &logger_) |
There was a problem hiding this comment.
I'm getting the following exception on macos occasionally, the logger_ is not a valid Logger, could it because it's not created here?:
There was a problem hiding this comment.
Not sure. I fixed the non-OK issue on Linux. See if that works.
There was a problem hiding this comment.
Fix a UAF based on ASAN trace so should be fixed now.
|
@pdillinger has updated the pull request. You must reimport the pull request before landing. |
|
@pdillinger has updated the pull request. You must reimport the pull request before landing. |
|
@pdillinger has updated the pull request. You must reimport the pull request before landing. |
|
@pdillinger has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary:
In preparation for more support for file Temperatures in BackupEngine,
this change does some test refactoring:
BackupEngineTest::FileTemperatures, with some updates to make it work
in the new home. This test will soon be expanded for deeper backup work.
support sharing because of above moved test, but split off the "no link"
part to the test needing it.
because going through Env file interfaces doesn't support temperatures.
parameter to FsyncWithDirOptions, which was required because this
limitation caused a crash only after moving to higher fidelity of
FileSystem interface (vs. LegacyDirectoryWrapper throwing away some
parameter details)
backupable_options_->engine_options_as part of the ongoingwork to get rid of the obsolete "backupable" naming.
Test Plan: test code updates only