compression_per_level should be used for flush and changeable
#9658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrambacher
reviewed
Mar 5, 2022
| @@ -271,6 +270,7 @@ struct MutableCFOptions { | |||
| Temperature bottommost_temperature; | |||
|
|
|||
| uint64_t sample_for_compression; | |||
| std::vector<CompressionType> compression_per_level; | |||
There was a problem hiding this comment.
Minor nit: Can we try to keep the order of the structure elements the same between the ColumnFamilyOptions and the Mutable/Immutable ones? It makes it easier for comparison/checking purposes.
There was a problem hiding this comment.
MutableCFOptions groups the options by memtable, compaction, blob, misc, we're putting it to misc group with other compression options:
https://github.com/facebook/rocksdb/blob/6cb7d64259110345a86ad48252df8dacd8c623cd/options/cf_options.h#L246-L260
jay-zhuang
force-pushed
the
compression_per_level
branch
from
74170b5
to
6fd3504
Compare
jay-zhuang
changed the title
compression_per_level should be used for flush and dynamic changeable
jay-zhuang
changed the title
compression_per_level should be used for flush and dynamic changeablecompression_per_level should be used for flush and changeable
|
@jay-zhuang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compression_per_leveldynamical changeable withSetOptions;compression_per_levelis not used for flush;Test Plan: CI