Rename mutable_cf_options to signify explicity copy #9666
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ezgicicek has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Thanks @ezgicicek for the improvement. It looks like your branch is too old, can you try rebasing to latest main? |
|
@ezgicicek has updated the pull request. You must reimport the pull request before landing. |
|
@ezgicicek has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
I tried rebasing from the UI here but not sure why |
riversand963
approved these changes
Mar 8, 2022
There was a problem hiding this comment.
I don't think it's caused by your PR. Thanks @ezgicicek for the improvement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signify explicit copy with comment and better name for variable
mutable_cf_options