Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build for io_uring #9690

Closed
wants to merge 5 commits into from
Closed

Fix build for io_uring #9690

wants to merge 5 commits into from

Conversation

jay-zhuang
Copy link
Contributor

Minor fix for build failure:

./env/io_posix.h:68:33: error: unused parameter 'len' [-Werror=unused-parameter]
   68 |                          size_t len, size_t iov_len, bool async_read,
      |                          ~~~~~~~^~~

Only happens for release build with io_uring.

Test Plan: build pass with io_uring

@facebook-github-bot
Copy link
Contributor

@jay-zhuang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@jay-zhuang has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@jay-zhuang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

akankshamahajan15
akankshamahajan15 approved these changes Mar 13, 2022
View reviewed changes
Copy link
Contributor

@akankshamahajan15 akankshamahajan15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@jay-zhuang
maybe fix
531df5c
@jay-zhuang
make format
c730bce
@jay-zhuang
Revert "make format"
bc2ef20 
This reverts commit ec97062245c077f60f107f148108e18010e0881f.
@jay-zhuang
Revert "maybe fix"
5f3cd7e 
This reverts commit 8c54817f4b6b8105595ceeb552fa2cd6515e0107.
@jay-zhuang
try different fix
c2ad7d2
@facebook-github-bot
Copy link
Contributor

@jay-zhuang has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@jay-zhuang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akankshamahajan15 akankshamahajan15 akankshamahajan15 approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jay-zhuang @facebook-github-bot @akankshamahajan15