Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new checksum type kXXH3 to Java API #9749

Closed

Conversation

alanpaxton
Copy link
Contributor

Fix #9720

And make a couple of incidental tests test the thing they were meant to test.

Copy link
Contributor

@jay-zhuang jay-zhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@facebook-github-bot
Copy link
Contributor

@jay-zhuang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@bremac
Copy link
Contributor

bremac commented Oct 24, 2022

FYI @alanpaxton, this PR didn't update toCppChecksumType, so setting the checksum type to XXH3 via the Java API does not work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kxxH3 is missing in java
5 participants