-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Env::IO_MID for the L0->L0 && L0->L1 compaction #9999
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It turns out not everyone has the same intuition on this so we need some data to show it is beneficial. For example, if you run db_bench -benchmarks=fillrandom
with a fixed write rate and rate limiter bytes/sec, does this PR increase the duration until stall happens or reduce the amount of stalling?
@ajkr
result with PR
result without PR
|
@ajkr Is there any more comments for this PR?:) |
I don't have more comments right now. We (RocksDB team) just need to find time to discuss/evaluate it more internally since this would be a change to behavior that's been there forever and affects many workloads. |
Fixes #9918
Test Plan: