Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't force en_US.utf-8 as locale as it mgiht not exist. #818

Closed
wants to merge 1 commit into from
Closed

Don't force en_US.utf-8 as locale as it mgiht not exist. #818

wants to merge 1 commit into from

Commits on Jan 20, 2024

  1. Don't force en_US.utf-8 as locale as it mgiht not exist. 

    glibc does not generate all combinations of locales by default, and Python
fails when requesting to enforce a locale that does not exist.

Since the extension is not caring for the translation chosen, but rather
only trying to enforce UTF-8 support, use the C.UTF-8 locale which is
guaranteed to exist as per https://www.gnu.org/software/libc/manual/html_node/Choosing-Locale.html

Fixes facebook#814 where VSCode would intermittently be unable to identify
a valid Sapling checkout and/or pull from a repository.
    @Flameeyes
    Flameeyes committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    70799fa View commit details
    Browse the repository at this point in the history