Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed / motivation ?
I had came to a need of stylex rollup-plugin in the cjs flavor. See this issue for relevant context. #451
So I added it. My PR is very much inspired by the current implementation in
packages/styles/package.json
Linked PR/Issues
Fixes #451
Additional Context
The rollup-plugin now generates
lib/*
andlib/es/*
folders. See screenshot:I had run all the tests and lints. But as I'm unfamiliar with the repository. I'd gladly ask for a double check that I didn't break anything vital. 🙏
What I have manually tested:
lib/es/index.mjs
is identical with the oldlib/index.js
Tagging @nmn as a follow-up to our discussion
Pre-flight checklist
Contribution Guidelines