Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add trimming for TestSaveConfig config file assertion #317

Closed
wants to merge 1 commit into from

Conversation

aphostrophy
Copy link
Member

Summary:
Save(...) calls .SaveTo(...) which for some reasons behave differently on different systems.

For example, when testing internally, it adds whitespace between the fields such that all "=" are aligned vertically. However when tests are executed in another environment (e.g. local with go test), it doesn't have this behaviour.

This diff removes the usage of .SaveTo(...) from the ini library and just do a normal bytes write to the filesystem for saving config.

Reviewed By: leoleovich

Differential Revision: D52625023

Summary:
Save(...) calls .SaveTo(...) which for some reasons behave differently on different systems.

For example, when testing internally, it adds whitespace between the fields such that all "=" are aligned vertically. However when tests are executed in another environment (e.g. local with go test), it doesn't have this behaviour.

This diff removes the usage of .SaveTo(...) from the ini library and just do a normal bytes write to the filesystem for saving config.

Reviewed By: leoleovich

Differential Revision: D52625023
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 9, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52625023

Copy link
Contributor

@leoleovich leoleovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in d1456d1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants