-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support hardware timestamps #346
Conversation
This pull request was exported from Phabricator. Differential Revision: D56255701 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks v good. Nits.
ntp/responder/server/config.go
Outdated
Workers int | ||
phcoffset time.Duration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not phcOffset
?
ntp/responder/server/server.go
Outdated
@@ -99,6 +99,19 @@ func (s *Server) Start(ctx context.Context, cancelFunc context.CancelFunc) { | |||
} | |||
}() | |||
|
|||
// Run PHC-SYS offset periodically | |||
if s.Config.TimestampType == timestamp.HWTIMESTAMP { | |||
log.Infof("Starting peridic measurement between phc and sysclock") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
log.Infof("Starting peridic measurement between phc and sysclock") | |
log.Infof("Starting periodic measurement between phc and sysclock") |
dbded29
to
61e637d
Compare
Summary: Pull Request resolved: facebook#346 Add an option to enable hardware timestamps on ntp responder. Default is software (same behaviour). Apart from enabling hardware timestamper (which is only supported on Linux) we also run periodic PHC-SYS measurements Differential Revision: D56255701
Summary: Pull Request resolved: facebook#346 Add an option to enable hardware timestamps on ntp responder. Default is software (same behaviour). Apart from enabling hardware timestamper (which is only supported on Linux) we also run periodic PHC-SYS measurements Differential Revision: D56255701
61e637d
to
3f731b1
Compare
Summary: Pull Request resolved: facebook#346 Add an option to enable hardware timestamps on ntp responder. Default is software (same behaviour). Apart from enabling hardware timestamper (which is only supported on Linux) we also run periodic PHC-SYS measurements Differential Revision: D56255701
3f731b1
to
ef7fc00
Compare
Summary: Pull Request resolved: facebook#346 Add an option to enable hardware timestamps on ntp responder. Default is software (same behaviour). Apart from enabling hardware timestamper (which is only supported on Linux) we also run periodic PHC-SYS measurements Differential Revision: D56255701
ef7fc00
to
e00871e
Compare
Summary: Pull Request resolved: facebook#346 Add an option to enable hardware timestamps on ntp responder. Default is software (same behaviour). Apart from enabling hardware timestamper (which is only supported on Linux) we also run periodic PHC-SYS measurements Differential Revision: D56255701
e00871e
to
87dee89
Compare
Summary: Pull Request resolved: facebook#346 Add an option to enable hardware timestamps on ntp responder. Default is software (same behaviour). Apart from enabling hardware timestamper (which is only supported on Linux) we also run periodic PHC-SYS measurements Reviewed By: pmazzini Differential Revision: D56255701
87dee89
to
952cee9
Compare
This pull request has been merged in 2be3b62. |
Summary:
Add an option to enable hardware timestamps on ntp responder.
Default is software (same behaviour).
Apart from enabling hardware timestamper (which is only supported on Linux) we also run periodic PHC-SYS measurements
Differential Revision: D56255701