support hardware timestamps #346
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D56255701 |
t3lurid3
reviewed
Apr 19, 2024
ntp/responder/server/config.go
Outdated
| Workers int | ||
| phcoffset time.Duration |
ntp/responder/server/server.go
Outdated
| @@ -99,6 +99,19 @@ func (s *Server) Start(ctx context.Context, cancelFunc context.CancelFunc) { | |||
| } | |||
| }() | |||
|
|
|||
| // Run PHC-SYS offset periodically | |||
| if s.Config.TimestampType == timestamp.HWTIMESTAMP { | |||
| log.Infof("Starting peridic measurement between phc and sysclock") | |||
There was a problem hiding this comment.
Suggested change
| log.Infof("Starting peridic measurement between phc and sysclock") | |
| log.Infof("Starting periodic measurement between phc and sysclock") |
leoleovich
force-pushed
the
export-D56255701
branch
from
dbded29
to
61e637d
Compare
leoleovich
added a commit
to leoleovich/time
that referenced
this pull request
Apr 19, 2024
Summary: Pull Request resolved: facebook#346 Add an option to enable hardware timestamps on ntp responder. Default is software (same behaviour). Apart from enabling hardware timestamper (which is only supported on Linux) we also run periodic PHC-SYS measurements Differential Revision: D56255701
leoleovich
added a commit
to leoleovich/time
that referenced
this pull request
Apr 19, 2024
Summary: Pull Request resolved: facebook#346 Add an option to enable hardware timestamps on ntp responder. Default is software (same behaviour). Apart from enabling hardware timestamper (which is only supported on Linux) we also run periodic PHC-SYS measurements Differential Revision: D56255701
leoleovich
force-pushed
the
export-D56255701
branch
from
61e637d
to
3f731b1
Compare
leoleovich
added a commit
to leoleovich/time
that referenced
this pull request
Apr 19, 2024
Summary: Pull Request resolved: facebook#346 Add an option to enable hardware timestamps on ntp responder. Default is software (same behaviour). Apart from enabling hardware timestamper (which is only supported on Linux) we also run periodic PHC-SYS measurements Differential Revision: D56255701
leoleovich
force-pushed
the
export-D56255701
branch
from
3f731b1
to
ef7fc00
Compare
leoleovich
added a commit
to leoleovich/time
that referenced
this pull request
Apr 19, 2024
Summary: Pull Request resolved: facebook#346 Add an option to enable hardware timestamps on ntp responder. Default is software (same behaviour). Apart from enabling hardware timestamper (which is only supported on Linux) we also run periodic PHC-SYS measurements Differential Revision: D56255701
leoleovich
force-pushed
the
export-D56255701
branch
from
ef7fc00
to
e00871e
Compare
leoleovich
added a commit
to leoleovich/time
that referenced
this pull request
Apr 19, 2024
Summary: Pull Request resolved: facebook#346 Add an option to enable hardware timestamps on ntp responder. Default is software (same behaviour). Apart from enabling hardware timestamper (which is only supported on Linux) we also run periodic PHC-SYS measurements Differential Revision: D56255701
leoleovich
force-pushed
the
export-D56255701
branch
from
e00871e
to
87dee89
Compare
Summary: Pull Request resolved: facebook#346 Add an option to enable hardware timestamps on ntp responder. Default is software (same behaviour). Apart from enabling hardware timestamper (which is only supported on Linux) we also run periodic PHC-SYS measurements Reviewed By: pmazzini Differential Revision: D56255701
leoleovich
force-pushed
the
export-D56255701
branch
from
87dee89
to
952cee9
Compare
|
This pull request has been merged in 2be3b62. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add an option to enable hardware timestamps on ntp responder.
Default is software (same behaviour).
Apart from enabling hardware timestamper (which is only supported on Linux) we also run periodic PHC-SYS measurements
Differential Revision: D56255701