Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test P-384 #84

Merged
merged 1 commit into from
Feb 8, 2023
Merged

Test P-384 #84

merged 1 commit into from
Feb 8, 2023

Conversation

daxpedda
Copy link
Contributor

@daxpedda daxpedda commented Dec 7, 2022

This just tests P-384 support and builds on top of RustCrypto/elliptic-curves#600.
We still have to wait for new versions to be released.

Builds on top of #101.
Fixes #81.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 7, 2022
@daxpedda
Copy link
Contributor Author

daxpedda commented Dec 9, 2022

Rebased on #85.

@daxpedda
Copy link
Contributor Author

Rebased after #85.

@daxpedda
Copy link
Contributor Author

daxpedda commented Feb 1, 2023

RustCrypto/elliptic-curves#600 was just merged.
This now build on top of #101.

This would be ready to merge as soon as #101 is merged, which relies on a new release of elliptic-curve and RustCrypto/traits#1238.

@daxpedda
Copy link
Contributor Author

daxpedda commented Feb 3, 2023

Everything upstream was merged now, so we are only waiting for #101.

@daxpedda
Copy link
Contributor Author

daxpedda commented Feb 8, 2023

This is good to go now too!

@daxpedda daxpedda mentioned this pull request Feb 8, 2023
Copy link
Contributor

@kevinlewi kevinlewi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome to see that everything works seamlessly.

@kevinlewi kevinlewi merged commit 83eb78b into facebook:main Feb 8, 2023
@daxpedda daxpedda mentioned this pull request Nov 10, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

P384 support
3 participants