Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup constructors #16

Closed
ldemailly opened this issue Jul 25, 2015 · 0 comments
Closed

cleanup constructors #16

ldemailly opened this issue Jul 25, 2015 · 0 comments

Comments

@ldemailly
Copy link
Contributor

sender for instance has too many constructors and they are chained in a bad way like changing the ports vector

the command line also should exercise all/most of them

it's related to WdtBase refactoring too
ldemailly added a commit that referenced this issue Jul 29, 2015
@ldemailly
fix constructor and command line such as url can be passed from recei…
933db43 
…ver to sender

Summary: fix constructor and command line such as url can be passed from receiver to sender

closes #25, closes #9, progress on #16

note: there is an incompatible change that you must specify a -transfer_id if you aren't going to use the URL as the default behavior is now to generate a unique id on the receiver with the expectations the url is used on the sender to connect (which is what the wdt_e2e_simple_test.sh demonstrates) but if you use the old style command line you must now specify the same non empty -transfer_id on both side

Reviewed By: @nikunjy

Differential Revision: D2289794
ldemailly added a commit to ldemailly/wdt that referenced this issue Jul 29, 2015
@ldemailly
fix constructor and command line such as url can be passed from recei…
c0526b7 
…ver to sender

Summary: fix constructor and command line such as url can be passed from receiver to sender

closes facebook#25, closes facebook#9, progress on facebook#16

note: there is an incompatible change that you must specify a -transfer_id if you aren't going to use the URL as the default behavior is now to generate a unique id on the receiver with the expectations the url is used on the sender to connect (which is what the wdt_e2e_simple_test.sh demonstrates) but if you use the old style command line you must now specify the same non empty -transfer_id on both side

Reviewed By: @nikunjy

Differential Revision: D2289794
ldemailly referenced this issue Oct 6, 2016
@uddipta
Sender in WDT is created before preparing snapshot, also multiple cle…
6c656c3 
…anups

Summary:
1) Sender constructor cleanup
2) Removing WDT support from rocks log server code
3) Sender is created before preparing snapshots
4) Sender is not run in thrift serving thread pool
5) Fixing stargate-wdt destination identifier problem, added a test for that

Reviewed By: ldemailly

Differential Revision: D3887608

fbshipit-source-id: c0ea210b468fa13a7715f6037ef7747aff5b5454
@nxtreaming nxtreaming mentioned this issue Dec 8, 2016
Closed
@zxpan zxpan mentioned this issue Dec 17, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ldemailly