Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make connection uri read as either command line parameter (without --option) or stdin (for receiver | sender) #9

Closed
ldemailly opened this issue Jul 23, 2015 · 2 comments
Closed

make connection uri read as either command line parameter (without --option) or stdin (for receiver | sender) #9

ldemailly opened this issue Jul 23, 2015 · 2 comments
Assignees
@ldemailly

Comments

@ldemailly
Copy link
Contributor

the new connection uri way of connecting to wdt should be the only optional parameter without requiring a --

ideally we should be able to tell from the url itself maybe if this is sender or receiver yet allow to pass one to the other (the 2 goals conflicts)
@ldemailly ldemailly changed the title make connection uri read as either command line parameter (without --option) make connection uri read as either command line parameter (without --option) or stdin (for receiver | sender) Jul 23, 2015
@ldemailly ldemailly self-assigned this Jul 28, 2015
@ldemailly
Copy link
Contributor Author

and change the test script to use that mode

also ensure transferid is generated in the url

@ldemailly
Copy link
Contributor Author

also consider forking/daemon mode for receiver

ldemailly added a commit to ldemailly/wdt that referenced this issue Jul 29, 2015
@ldemailly
fix constructor and command line such as url can be passed from recei…
c0526b7 
…ver to sender

Summary: fix constructor and command line such as url can be passed from receiver to sender

closes facebook#25, closes facebook#9, progress on facebook#16

note: there is an incompatible change that you must specify a -transfer_id if you aren't going to use the URL as the default behavior is now to generate a unique id on the receiver with the expectations the url is used on the sender to connect (which is what the wdt_e2e_simple_test.sh demonstrates) but if you use the old style command line you must now specify the same non empty -transfer_id on both side

Reviewed By: @nikunjy

Differential Revision: D2289794
@nxtreaming nxtreaming mentioned this issue Dec 8, 2016
Closed
@zxpan zxpan mentioned this issue Dec 17, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ldemailly ldemailly

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ldemailly