Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transferid not set in the url returned by cmd line receiver #25

Closed
ldemailly opened this issue Jul 28, 2015 · 0 comments
Closed

transferid not set in the url returned by cmd line receiver #25

ldemailly opened this issue Jul 28, 2015 · 0 comments
Assignees
@ldemailly

Comments

@ldemailly
Copy link
Contributor

[ldemailly@devbig074 fbcode-hg]$ _bin/wdt/wdt --start_port 0 -directory /tmp/wdtTest/x2
I0728 14:18:53.806941 2208757 wdtCmdLine.cpp:119] Running WDT 1.14.1507270-fbcode p 14
I0728 14:18:53.807461 2208757 WdtBase.cpp:300] Generated a transfer id 918338613
I0728 14:18:53.807471 2208757 WdtBase.cpp:268] using wdt protocol version 14
I0728 14:18:53.807497 2208757 WdtBase.cpp:261] Setting transfer id
I0728 14:18:53.807606 2208757 Receiver.cpp:156] Registered 8 sockets
I0728 14:18:53.807622 2208757 Receiver.cpp:168] Transfer id
I0728 14:18:53.807632 2208757 wdtCmdLine.cpp:140] Starting receiver with connection url
wdt://devbig074.prn2.facebook.com?ports=36005,40903,38821,43869,64260,41130,59955,44966&protocol=14&id=
ldemailly added a commit to ldemailly/wdt that referenced this issue Jul 29, 2015
@ldemailly
fix constructor and command line such as url can be passed from recei…
c0526b7 
…ver to sender

Summary: fix constructor and command line such as url can be passed from receiver to sender

closes facebook#25, closes facebook#9, progress on facebook#16

note: there is an incompatible change that you must specify a -transfer_id if you aren't going to use the URL as the default behavior is now to generate a unique id on the receiver with the expectations the url is used on the sender to connect (which is what the wdt_e2e_simple_test.sh demonstrates) but if you use the old style command line you must now specify the same non empty -transfer_id on both side

Reviewed By: @nikunjy

Differential Revision: D2289794
@ldemailly ldemailly self-assigned this Jul 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ldemailly ldemailly

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ldemailly