Make playground links shorter #1516
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request was exported from Phabricator. Differential Revision: D52161884 |
NickGerleman
force-pushed
the
export-D52161884
branch
from
86e4391
to
24a3e66
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Dec 14, 2023
Summary: Right now playground links are URL encoded base64 of the code content. This leads to some pretty long links. Running a service, or needing to auth to some other service, seems like a lot more headache than it is worth, so this change instead tries to make the URLs a bit more reasonable. One minor saving is that we're URL encoding base64, instead of just representing using the url-safe variant of base64. But we can get more savings, even in small examples, using compression. This adds a popular, small, library to do that. Differential Revision: D52161884
|
This pull request was exported from Phabricator. Differential Revision: D52161884 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Dec 14, 2023
Summary: Right now playground links are URL encoded base64 of the code content. This leads to some pretty long links. Running a service, or needing to auth to some other service, seems like a lot more headache than it is worth, so this change instead tries to make the URLs a bit more reasonable. One minor saving is that we're URL encoding base64, instead of just representing using the url-safe variant of base64. But we can get more savings, even in small examples, using compression. This adds a popular, small, library to do that. Differential Revision: D52161884
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Dec 14, 2023
Summary: Right now playground links are URL encoded base64 of the code content. This leads to some pretty long links. Running a service, or needing to auth to some other service, seems like a lot more headache than it is worth, so this change instead tries to make the URLs a bit more reasonable. One minor saving is that we're URL encoding base64, instead of just representing using the url-safe variant of base64. But we can get more savings, even in small examples, using compression. This adds a popular, small, library to do that. Differential Revision: D52161884
NickGerleman
force-pushed
the
export-D52161884
branch
from
24a3e66
to
abd1b1a
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Dec 15, 2023
Summary: Right now playground links are URL encoded base64 of the code content. This leads to some pretty long links. Running a service, or needing to auth to some other service, seems like a lot more headache than it is worth, so this change instead tries to make the URLs a bit more reasonable. One minor saving is that we're URL encoding base64, instead of just representing using the url-safe variant of base64. But we can get more savings, even in small examples, using compression. This adds a popular, small, library to do that. Differential Revision: D52161884
|
This pull request was exported from Phabricator. Differential Revision: D52161884 |
Summary: Right now playground links are URL encoded base64 of the code content. This leads to some pretty long links. Running a service, or needing to auth to some other service, seems like a lot more headache than it is worth, so this change instead tries to make the URLs a bit more reasonable. One minor saving is that we're URL encoding base64, instead of just representing using the url-safe variant of base64. But we can get more savings, even in small examples, using compression. This adds a popular, small, library to do that. Reviewed By: yungsters Differential Revision: D52161884
NickGerleman
force-pushed
the
export-D52161884
branch
from
abd1b1a
to
87ccedf
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52161884 |
|
This pull request has been merged in eeeb2ca. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Right now playground links are URL encoded base64 of the code content. This leads to some pretty long links.
Running a service, or needing to auth to some other service, seems like a lot more headache than it is worth, so this change instead tries to make the URLs a bit more reasonable.
One minor saving is that we're URL encoding base64, instead of just representing using the url-safe variant of base64. But we can get more savings, even in small examples, using compression. This adds a popular, small, library to do that.
Differential Revision: D52161884