Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase that number of bit in YGStyle and YGLayout to resolve the sign issue. #846

Closed
wants to merge 1 commit into from

Conversation

anyktx
Copy link

@anyktx anyktx commented Jan 5, 2019

This may not be the best way to solve the issue of [https://github.com//issues/845], but it is an effective one.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@davidaurelio
Copy link
Contributor

Thank you for reporting – I will replace these with a custom bitfield implementation to make it work reliably.

@davidaurelio davidaurelio self-requested a review January 28, 2019 21:36
@davidaurelio davidaurelio self-assigned this Feb 1, 2019
@Adlai-Holler
Copy link
Contributor

+1 to get this in the bank if possible. My C++ compiler refuses to build YGNode.h because of the implicit truncation changing the sign of the value from 4 to -4.

@Adlai-Holler
Copy link
Contributor

@davidaurelio One way to fix this simply is to change YG_ENUM_BEGIN from int to unsigned

@Adlai-Holler
Copy link
Contributor

cc #870

@davidaurelio davidaurelio removed their assignment Jun 19, 2020
@davidaurelio
Copy link
Contributor

I fixed this last August. However, I cannot close here since I am no longer at FB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants