Use unsigned for enums to avoid bitfield compiler warning #870
Conversation
There was a problem hiding this comment.
@davidaurelio is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This causes a bunch of internal failures at FB. Gonna have to work through them one by one |
|
@davidaurelio thank you for all of your hard work! I've seen that the android build was failing in the React Native repo. Is it related? |
|
No, it’s some internal, non-OSS stuff. Unfortunately, we do have lots of different compiler setups, too :-D |
|
This won’t land in this form, sorry. I am getting hard compiler errors. Will replace this with a portable bitfield implementation. |
|
@Adlai-Holler @wokalski I have landed changing to enum storage today, e.g. https://github.com/facebook/yoga/blob/master/yoga/YGStyle.h#L76-L98 This should fix the problem. |
Fixes #845 without adding more bits.