-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zstd_legacy.h is missing - include attempted when ZSTD_LEGACY_SUPPORT is defined #113
Comments
It is present in the The provided |
Ah, my mistake - I was updating ZStd in lzbench, which doesn't have the folder. How about defaulting ZSTD_LEGACY_SUPPORT to 0, so that the legacy folder is only required if specifically desired? |
It's a matter of preference. |
Sure, understood. I was assuming from the major version being zero, that api changes were assumed to be okay at any time. That is minor issue with semantic versioning before the first major release. |
Actually, thinking again about it, something I could do and feels logical :
This way, when including zstd into another project, the expectation, in general, is to not need additional legacy files. |
That looks to be a very good solution to me. It is difficult to balance having the code out there for people to use and report bugs etc, before committing to a major version. Keeping the main lib folder as current and self sufficient would make adoption easy, while minimizing the penalty for early adoptors to migrate to changes. |
pushed into dev branch |
ZSTD_LEGACY_SUPPORT if not defined is defined to 1 in zstd_decompress.c
Then later in the file:
if defined(ZSTD_LEGACY_SUPPORT) && (ZSTD_LEGACY_SUPPORT==1)
include "zstd_legacy.h"
endif
However, zstd_legacy.h isn't present on github.
The text was updated successfully, but these errors were encountered: