Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: Check for existing custom target 'uninstall' #1619

Merged
merged 1 commit into from Jun 10, 2019
Merged

CMake: Check for existing custom target 'uninstall' #1619

merged 1 commit into from Jun 10, 2019

Conversation

ghost
Copy link

@ghost ghost commented May 26, 2019

Hi,
I'm using add_subdirectory to include zstd in my project. Another library that I'm using also creates a custom target called uninstall.

This change checks that the uninstall target doesn't exist before it creates it.

felixhandte
felixhandte approved these changes Jun 10, 2019
View reviewed changes
Copy link
Contributor

@felixhandte felixhandte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable, since, as I understand it, the use of zstd in this way would not include executing zstd's stock installation.

@Cyan4973 Cyan4973 merged commit c601622 into facebook:dev Jun 10, 2019
@felixhandte felixhandte mentioned this pull request Jul 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felixhandte @Cyan4973 @facebook-github-bot