Install MSVC runtime shared libraries (DLL) with cmake #2221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @emmenlau! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
terrelln
approved these changes
Jun 30, 2020
terrelln
approved these changes
Jun 30, 2020
|
Thanks for the PR @emmenlau! |
|
Thanks for the quick response! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cmake based build currently does not install MSVC shared libraries. This seems to be caused by a rather simple issue: The cmake install command is missing the
RUNTIMEcomponent (see https://cmake.org/cmake/help/latest/command/install.html#installing-targets). The usual install target directory for theRUNTIMEisCMAKE_INSTALL_BINDIR.This PR adds the
RUNTIMEcomponent to the install command. This should not have any negative consequences for any users. The only behavioral change should be that the shared library (dll) files will be installed intoCMAKE_INSTALL_BINDIRon MSVC, which should be a purely positive effect.