Avoid Using Deprecated Functions in Deprecated Code #2897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`lib/deprecated` is no longer built by zstd's bundled build files. However, users may try to build these files when they import the source tree into their own build systems. And if they have `-Wdeprecated-declarations` on, this can produce warnings. This PR migrates these files away from using deprecated declarations. This addresses facebook#2767.
Cyan4973
reviewed
Dec 2, 2021
Cyan4973
reviewed
Dec 2, 2021
Cyan4973
approved these changes
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lib/deprecatedis no longer built by zstd's bundled build files. However,users may try to build these files when they import the source tree into
their own build systems. And if they have
-Wdeprecated-declarationson,this can produce warnings.
This PR migrates these files away from using deprecated declarations.
This addresses #2767.