This repository has been archived by the owner on Sep 26, 2018. It is now read-only.
Call/SMS reporting:- #65
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivkumarsah
force-pushed
the
sprint3_pr_call_report
branch
from
cebc8a1
to
4d36b74
Compare
|
@shivkumarsah updated the pull request - view changes |
shivkumarsah
force-pushed
the
sprint3_pr_call_report
branch
from
4d36b74
to
c06a1e1
Compare
|
@shivkumarsah updated the pull request - view changes |
|
Thanks! For changes like this that impact UI, could you please include a screenshot? |
shaddi
suggested changes
Aug 4, 2017
| <script src="https://cdnjs.cloudflare.com/ajax/libs/d3/3.1.5/d3.min.js"></script> | ||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/nvd3/1.1.13-beta/nv.d3.min.js"></script> | ||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/moment.js/2.9.0/moment.min.js"></script> | ||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/bootstrap-datetimepicker/4.14.30/js/bootstrap-datetimepicker.min.js"></script> |
There was a problem hiding this comment.
This is already included above
| <script src="https://cdnjs.cloudflare.com/ajax/libs/nvd3/1.1.13-beta/nv.d3.min.js"></script> | ||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/moment.js/2.9.0/moment.min.js"></script> | ||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/bootstrap-datetimepicker/4.14.30/js/bootstrap-datetimepicker.min.js"></script> | ||
| <script src="https://cdn.datatables.net/1.10.15/js/jquery.dataTables.min.js"></script> |
| <script src="https://cdnjs.cloudflare.com/ajax/libs/react/0.12.2/react.min.js"></script> | ||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/react/0.12.2/JSXTransformer.js"></script> | ||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/d3/3.1.5/d3.min.js"></script> | ||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/nvd3/1.1.13-beta/nv.d3.min.js"></script> |
There was a problem hiding this comment.
This is included above. Let's keep script imports together?
There was a problem hiding this comment.
This is for chat js files. Above includes files are css style. CSS files are included in top of page in 'pagestyle' block to load pages fast, and js files are added in bottom '"js" block
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review Call and SMS report which include the below features: