Skip to content
This repository has been archived by the owner on Sep 26, 2018. It is now read-only.

Denominations - re-design #74

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

shivkumarsah
Copy link
Contributor

@shivkumarsah shivkumarsah commented Jul 28, 2017

Please review denomination UI changes which include the below features:-

  • New UI design
  • Continuous range
  • Confirm before apply change
  • Start/End amount integer value
  • Bulk delete

Screenshot:-

denominations_list
denominations_actions
denominations_add-edit

@@ -537,6 +605,9 @@ def post(self, request):
CURRENCIES[currency]).amount_raw
validity_days = int(request.POST.get('validity_days')) or 0

print "start_amount_raw = ", start_amount_raw
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume these are debug statements that should be removed?

@shaddi
Copy link
Contributor

shaddi commented Jul 28, 2017

Hi there, can you please provide screenshots for the UI changes?

@facebook-github-bot
Copy link

@shivkumarsah updated the pull request - view changes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants