Documenting Fedora 29 build process. #55
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
N.B. Circleci says that test 1779 fails, but on Fedora it runs fine. |
There was a problem hiding this comment.
Took a little while, as was doing full-builds for each. But tested on Fedora28 (29 not yet available for LXC) which appeared to build ok. But on Xenial the build failed. I did some brief checks and it looks like on Xenial the variable Boost_LIBRARIES is not populated and so the components are not included in the link?
| cd mstch | ||
| mkdir build | ||
| cd build | ||
| make && make install |
There was a problem hiding this comment.
Needs a CMake step to configure the build:
cmake ..
I believe the make install will either need to be installed to a specific (staging) directory; or installed with sudo permissions.
| @@ -4,7 +4,7 @@ | |||
| # This source code is licensed under the BSD-style license found in the | |||
| # LICENSE file in the root directory of this source tree. | |||
|
|
|||
| FROM fedora:25 | |||
There was a problem hiding this comment.
While I think its good that we only keep a generic Fedora; rather than populating the tree with docker files for Fedora 27, 28 and 29; it is best to be specific in the Dockerfile; this allows people picking up the file to get the same configuration as we test against.
There was a problem hiding this comment.
@calebmarchent has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
…les, exact fedora version in dockerfile
There was a problem hiding this comment.
@mickvav has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
May be not final - needed some cmake-related expertise: on Fedora cmake can't actually find boost_python3 library, although it exists. This commit documents workaround to this step, leading to seems-to-be-working build.