So many buffer overflows. Can't count.

[altf4]

Did a quick:

grep -rn "sprintf(" .

and got 215 results. Some of these seem pretty serious, too. Like:

https://github.com/OculusVR/RakNet/blob/master/Source/EmailSender.cpp#L153

Which has a good chance of being remote.

I may try to make a pull request later, but this is going to need a big change and I thought you ought to know soon. "Swiss cheese" comes to mind. I'd recommend taking care of the low hanging fruit first, replace all unsafe string functions with their safe counterparts. IE: snprintf() instead of sprintf(). I'd also not recommend running this on any important systems until then.

Other things to grep for which will give you loads of dangerous overflows in the RakNet code:

"strcat", "strcpy", and "memcpy"

Thanks

[phoem]

Ya I've been finding these too, started patching for them, however have no way to test. Anyone interested in working with me/testing before I submit patches?

[phoem]

Also not really a fan of strlen() all sizes should be tracked instead, should never need to use strlen()

[phoem]

As a rule of thumb i take the unsafe functions and redefine them to garbage so that if I do use one by mistake, compiling yells at me

[danoli3]

This is most likely due to the pre-C++11 IDE / compiler support.
If you want to make a PR, wrap the new functions in C++11 macros and keep the "unsafe"

#if __cplusplus > 199711L
    // C++11 +
#else
  // pre-C++11 or not defined by compiler.
#endif

[milesrout]

Is this going to be fixed? Has it been fixed? A project I am working on wants to use this as a dependency but we cannot until we know it doesn't have (known) vulnerabilities.

[atuljangra]

As far as I know, no one is working on this currently.