This repository has been archived by the owner on Jan 13, 2022. It is now read-only.
Fixed an 'comparison between pointer and integer' error on clang std=c++... #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since you're using C++11 mode, wouldn't nullptr be better? |
|
Yeah, for me it would, but I suppose that using 'NULL' is more independent of compiler and C++ version while also being accepted by clang under C++11. |
|
Duplicates part of #29 which is integrated in https://github.com/SLikeSoft/SLikeNet (incorporated in SLikeNet 0.1.0). |
crookedbard
approved these changes
Dec 7, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heya,
On Clang 3.4, with C++11 mode, there's a build error stemming from the comparison of integer and pointer. I don't think this should be an error according to the standard, but I figure that 'NULL' and 'false' are fully interchangeable in this context, so I changed the pointer comparison to be against 'NULL'.
Thanks,
tz