This repository has been archived by the owner on Jan 13, 2022. It is now read-only.
Fix mismatching allocation/deallocation in AutoPatcher/CreatePatch.cpp #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a mismatching allocation/deallocation of a char array in the AutoPatcher code: CreatePatch.cpp:529: *out = new char[*outSize]; CreatePatch.cpp:579: free(out); Mixing up new/delete and malloc/free is undefined behaviour and should be avoided.
alliekins
added a commit
that referenced
this pull request
Jul 9, 2014
Fix mismatching allocation/deallocation in AutoPatcher/CreatePatch.cpp
rhard
pushed a commit
to rhard/RakNet
that referenced
this pull request
Oct 26, 2017
Fix for GetIndexFromKey failing on forwardingRequestList
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a mismatching allocation/deallocation of a char array in
the AutoPatcher code:
CreatePatch.cpp:529: _out = new char[_outSize];
CreatePatch.cpp:579: free(out);
Mixing up new/delete and malloc/free is undefined behaviour and should be
avoided.