This repository has been archived by the owner on Feb 3, 2021. It is now read-only.
Fix shimmeringHighlightWidth documentation and deprecation attribute #56
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The property
shimmeringHighlightWidth
is causing 2 warnings with strict compiler flags.The first one is because placing
@deprecated
right after@abstract
in the documentation comment block causes the parser to think the@abstract
is empty.This is fixed by moving
@deprecated
at the end of the comment block.The second is caused by the method being documented as
@deprecated
but not marked as such with a compiler attribute. This is fixed by using theDEPRECATED_MSG_ATTRIBUTE
macro.