Skip to content
This repository has been archived by the owner on Dec 13, 2018. It is now read-only.

Datatip styling could use some padding for tables #98

Open
Gert-dev opened this issue Oct 18, 2017 · 0 comments
Open

Datatip styling could use some padding for tables #98

Gert-dev opened this issue Oct 18, 2017 · 0 comments

Comments

@Gert-dev
Copy link

Description

I'm trying to migrate my own tooltips/datatips to the datatip provider from atom-ide-ui. Datatips already support markdown, which is very neat and I've managed to get this working. However, I now noticed that tables originating from my markdown could use some additional padding between them. An example:

screenshot

The columns in Parameters pack rather tightly together. Previously, I just spaced them with some plain CSS, but this isn't possible with datatips anymore without resolving to a full custom React component:

Some copy-pastable code, but I'm not a designer, so use at your own risk 😄.

table {
    margin-left: 1.5em;
    margin-bottom: 1em;

    tr {
        td {
            padding-right: 1em;
            padding-bottom: 0.25em;
            vertical-align: top;
        }
    }
}

Expected Behavior

Some more padding would be added.

Actual Behavior

No padding is present.

Versions

  • Atom: 1.21.0
  • Client OS: Linux
  • atom-ide-ui: 0.5.1
Gert-dev added a commit to Gert-dev/php-ide-serenata that referenced this issue Oct 18, 2017
Datatips are much like our original tooltips, but they have a way to
become sticky, after which the user can drag them anywhere he wants
and also scroll through them. This pretty much removes the need for
a separate dock.

It also makes our UI consistent with that of other IDE packages and
allows us to benefit from UI and functionality improvements done in
atom-ide-ui itself.

Finally, this code is pretty much ready for use, except there are some
minor nitpicks in atom-ide-ui that I'd like ironed out before pushing
this in php-integrator:

  - facebookarchive/atom-ide-ui#98
  - facebookarchive/atom-ide-ui#99

References #315
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant