This repository has been archived by the owner on Feb 7, 2023. It is now read-only.
Use own benchmark and not any system pre-built ones: #1358
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(1) use the cmake files of the corresponding libs (2) allow static linkage of gtest and gbenchmark. (3) Helps removing the temp solution in facebookarchive#1112
|
👍 google/benchmark#463 is a nice solution. |
There was a problem hiding this comment.
@Yangqing is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Yangqing
added a commit
to Yangqing/caffe2
that referenced
this pull request
Oct 20, 2017
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 20, 2017
zou3519
pushed a commit
to zou3519/pytorch
that referenced
this pull request
Mar 30, 2018
Summary: (1) use the cmake files of the corresponding libs (2) allow static linkage of gtest and gbenchmark. (3) Helps removing the temp solution in pytorch#1112 We are yet to disable the installation of the benchmark library, and I have an open pull request at google/benchmark#463 - once it is merged I will do submodule update. cc lukeyeager pietern who had this issue before - hopefully this makes the solution cleaner. Closes facebookarchive/caffe2#1358 Differential Revision: D6111404 Pulled By: Yangqing fbshipit-source-id: 17468d32cef27f96e9445d119eb869c9c7913118
ezyang
pushed a commit
to ezyang/ATen
that referenced
this pull request
Apr 19, 2018
Summary: (1) use the cmake files of the corresponding libs (2) allow static linkage of gtest and gbenchmark. (3) Helps removing the temp solution in #1112 We are yet to disable the installation of the benchmark library, and I have an open pull request at google/benchmark#463 - once it is merged I will do submodule update. cc lukeyeager pietern who had this issue before - hopefully this makes the solution cleaner. Closes facebookarchive/caffe2#1358 Differential Revision: D6111404 Pulled By: Yangqing fbshipit-source-id: 17468d32cef27f96e9445d119eb869c9c7913118
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Apr 19, 2018
Summary: (1) use the cmake files of the corresponding libs (2) allow static linkage of gtest and gbenchmark. (3) Helps removing the temp solution in #1112 We are yet to disable the installation of the benchmark library, and I have an open pull request at google/benchmark#463 - once it is merged I will do submodule update. cc lukeyeager pietern who had this issue before - hopefully this makes the solution cleaner. Closes facebookarchive/caffe2#1358 Differential Revision: D6111404 Pulled By: Yangqing fbshipit-source-id: 17468d32cef27f96e9445d119eb869c9c7913118
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(1) use the cmake files of the corresponding libs
(2) allow static linkage of gtest and gbenchmark.
(3) Helps removing the temp solution in #1112
We are yet to disable the installation of the benchmark library, and I have an open pull request at google/benchmark#463 - once it is merged I will do submodule update.
cc @lukeyeager @pietern who had this issue before - hopefully this makes the solution cleaner.