Make decodeEntityRanges flow strict

Summary: Functionality shouldn't have changed, I just editeed types. I did have to edit and re-record a test that was wrong. Differential Revision: D19868736 fbshipit-source-id: e65885cd4565756e6669a17692e2f63d46f0d730
facebookarchive · Feb 13, 2020 · 7af73b7 · 7af73b7
1 parent d6527a9
commit 7af73b7
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 27 deletions.
diff --git a/src/model/encoding/__tests__/__snapshots__/decodeEntityRanges-test.js.snap b/src/model/encoding/__tests__/__snapshots__/decodeEntityRanges-test.js.snap
@@ -4,8 +4,8 @@ exports[`must decode when an entity is present 1`] = `
 Array [
   null,
   null,
-  "6",
-  "6",
+  6,
+  6,
   null,
 ]
 `;
@@ -14,11 +14,11 @@ exports[`must decode when an entity is present more than once 1`] = `
 Array [
   null,
   null,
-  "6",
-  "6",
+  6,
+  6,
   null,
-  "6",
-  "6",
+  6,
+  6,
   null,
 ]
 `;
@@ -27,11 +27,11 @@ exports[`must decode when multiple entities present 1`] = `
 Array [
   null,
   null,
-  "6",
-  "6",
+  6,
+  6,
   null,
-  "8",
-  "8",
+  8,
+  8,
   null,
 ]
 `;
@@ -69,16 +69,16 @@ Array [
   null,
   null,
   null,
-  "6",
-  "6",
-  "6",
-  "6",
-  "6",
-  "6",
+  6,
+  6,
+  6,
+  6,
+  6,
+  6,
   null,
   null,
-  "8",
-  "8",
+  8,
+  8,
   null,
 ]
 `;
diff --git a/src/model/encoding/__tests__/decodeEntityRanges-test.js b/src/model/encoding/__tests__/decodeEntityRanges-test.js
@@ -23,7 +23,7 @@ test('must decode when an entity is present', () => {
     {
       offset: 2,
       length: 2,
-      key: '6',
+      key: 6,
     },
   ]);
   expect(decoded).toMatchSnapshot();
@@ -34,12 +34,12 @@ test('must decode when multiple entities present', () => {
     {
       offset: 2,
       length: 2,
-      key: '6',
+      key: 6,
     },
     {
       offset: 5,
       length: 2,
-      key: '8',
+      key: 8,
     },
   ]);
   expect(decoded).toMatchSnapshot();
@@ -50,12 +50,12 @@ test('must decode when an entity is present more than once', () => {
     {
       offset: 2,
       length: 2,
-      key: '6',
+      key: 6,
     },
     {
       offset: 5,
       length: 2,
-      key: '6',
+      key: 6,
     },
   ]);
   expect(decoded).toMatchSnapshot();
@@ -66,12 +66,12 @@ test('must handle ranges that include surrogate pairs', () => {
     {
       offset: 6,
       length: 5,
-      key: '6',
+      key: 6,
     },
     {
       offset: 13,
       length: 2,
-      key: '8',
+      key: 8,
     },
   ]);
   expect(decoded).toMatchSnapshot();

diff --git a/src/model/encoding/decodeEntityRanges.js b/src/model/encoding/decodeEntityRanges.js
@@ -5,12 +5,14 @@
  * LICENSE file in the root directory of this source tree.
  *
  * @format
- * @flow
+ * @flow strict
  * @emails oncall+draft_js
  */
 
 'use strict';
 
+import type {EntityRange} from 'EntityRange';
+
 const UnicodeUtils = require('UnicodeUtils');
 
 const {substr} = UnicodeUtils;
@@ -20,7 +22,7 @@ const {substr} = UnicodeUtils;
  */
 function decodeEntityRanges(
   text: string,
-  ranges: Array<Object>,
+  ranges: Array<EntityRange>,
 ): Array<?string> {
   const entities = Array(text.length).fill(null);
   if (ranges) {