This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
Section tag is so commonly used. It will be very convenient to add them to the default block render map. #2074
Labels
Comments
|
Thanks for pointing this out @lisun0459, semantic tags like This looks like a very good first issue for a community member who would like to contribute a code change to Draft.js! I'm more than happy to assist being the point of contact and doing a code review. |
mmissey
pushed a commit
to mmissey/draft-js
that referenced
this issue
Mar 24, 2020
Summary: *Before* submitting a pull request, please make sure the following is done... 1. Fork the repo and create your branch from `master`. 2. If you've added code that should be tested, add tests! 3. If you've changed APIs, update the documentation. 4. Ensure that: * The test suite passes (`npm test`) * Your code lints (`npm run lint`) and passes Flow (`npm run flow`) * You have followed the [testing guidelines](https://github.com/facebook/draft-js/wiki/Testing-for-Pull-Requests) 5. If you haven't already, complete the [CLA](https://code.facebook.com/cla). Please use the simple form below as a guideline for describing your pull request. Thanks for contributing to Draft.js! - **Summary** Fixes facebookarchive#2074 Updated the default block render map to have the section and article tags. Pull Request resolved: facebookarchive#2212 Reviewed By: claudiopro Differential Revision: D18246366 Pulled By: mrkev fbshipit-source-id: 144f7721d92d6efcbb5c969ba992841eb9bd5f15
vilemj-Viclick
pushed a commit
to kontent-ai/draft-js
that referenced
this issue
Jul 16, 2020
Summary: *Before* submitting a pull request, please make sure the following is done... 1. Fork the repo and create your branch from `master`. 2. If you've added code that should be tested, add tests! 3. If you've changed APIs, update the documentation. 4. Ensure that: * The test suite passes (`npm test`) * Your code lints (`npm run lint`) and passes Flow (`npm run flow`) * You have followed the [testing guidelines](https://github.com/facebook/draft-js/wiki/Testing-for-Pull-Requests) 5. If you haven't already, complete the [CLA](https://code.facebook.com/cla). Please use the simple form below as a guideline for describing your pull request. Thanks for contributing to Draft.js! - **Summary** Fixes facebookarchive#2074 Updated the default block render map to have the section and article tags. Pull Request resolved: facebookarchive#2212 Reviewed By: claudiopro Differential Revision: D18246366 Pulled By: mrkev fbshipit-source-id: 144f7721d92d6efcbb5c969ba992841eb9bd5f15
|
These appear to be missing from the documentation at https://draftjs.org/docs/advanced-topics-custom-block-render-map? |
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this issue
Jul 4, 2023
Summary: *Before* submitting a pull request, please make sure the following is done... 1. Fork the repo and create your branch from `master`. 2. If you've added code that should be tested, add tests! 3. If you've changed APIs, update the documentation. 4. Ensure that: * The test suite passes (`npm test`) * Your code lints (`npm run lint`) and passes Flow (`npm run flow`) * You have followed the [testing guidelines](https://github.com/facebook/draft-js/wiki/Testing-for-Pull-Requests) 5. If you haven't already, complete the [CLA](https://code.facebook.com/cla). Please use the simple form below as a guideline for describing your pull request. Thanks for contributing to Draft.js! - **Summary** Fixes facebookarchive/draft-js#2074 Updated the default block render map to have the section and article tags. Pull Request resolved: facebookarchive/draft-js#2212 Reviewed By: claudiopro Differential Revision: D18246366 Pulled By: mrkev fbshipit-source-id: 144f7721d92d6efcbb5c969ba992841eb9bd5f15
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
<section>tag is so commonly used. It will be very convenient to add them to the default block render map.expect so！The text was updated successfully, but these errors were encountered: