This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
Fix copyright headers #1860
Closed
Fix copyright headers #1860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdelahousse
approved these changes
Sep 10, 2018
|
Nice. Looks good to me. |
There was a problem hiding this comment.
niveditc is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
mitermayer
approved these changes
Sep 11, 2018
|
Hi @niveditc, Why remove year from copyright notice? |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 3, 2019
…1964) Summary: **Summary** This PR follows up work started by niveditc on #1860 and suspended because of limitations with tooling. Let's give it another try. - Remove all copyright years - Correct copyright headers under `website/` referencing the MIT license - Inline `All rights reserved.` on the same line of the copyright - Fixes copyright headers of examples incorrectly using headers for source files The PR also normalizes copyright headers to BSD with patents grant, as some files were later added with the newest MIT license applied to React and other OSS projects. We should discuss the switch to MIT for Draft.js as well. **Test Plan** Manual inspection of files + `yarn lint` Pull Request resolved: #1964 Differential Revision: D13562427 fbshipit-source-id: 6a15d29ff56a6340ee2a0f13f278b207f1761d28
|
Superseded by #1964. |
jdecked
pushed a commit
to twitter-forks/draft-js
that referenced
this pull request
Oct 9, 2019
…acebookarchive#1964) Summary: **Summary** This PR follows up work started by niveditc on facebookarchive#1860 and suspended because of limitations with tooling. Let's give it another try. - Remove all copyright years - Correct copyright headers under `website/` referencing the MIT license - Inline `All rights reserved.` on the same line of the copyright - Fixes copyright headers of examples incorrectly using headers for source files The PR also normalizes copyright headers to BSD with patents grant, as some files were later added with the newest MIT license applied to React and other OSS projects. We should discuss the switch to MIT for Draft.js as well. **Test Plan** Manual inspection of files + `yarn lint` Pull Request resolved: facebookarchive#1964 Differential Revision: D13562427 fbshipit-source-id: 6a15d29ff56a6340ee2a0f13f278b207f1761d28
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The open source checkup tool told us that we were missing copyright headers on some files. I also found out that the recommendation is now to remove the date from these headers, so updated existing files via codemod.
Test Plan
None