This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
Upgrades flow-bin to 0.92.0 and mutes fbjs joinClasses error 🚨 #1989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@claudiopro has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
@claudiopro has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
claudiopro
changed the title
Closed
jdecked
pushed a commit
to twitter-forks/draft-js
that referenced
this pull request
Oct 9, 2019
…ookarchive#1989) Summary: **Summary** Fixes a CI build error (facebookarchive#1988) by adding a `$FlowExpectedError` annotation, and upgrading [flow-bin](https://www.npmjs.com/package/flow-bin) to 0.91.0 **Test Plan** ``` yarn run flow flow src ``` ``` → flow src The flow server's version didn't match the client's, so it exited. Going to launch a new one. Launching Flow server for /Users/procidac/Development/gh/claudiopro/draft-js/src Spawned flow server (pid=87525) Logs will go to /private/tmp/flow/zSUserszSprocidaczSDevelopmentzSghzSclaudioprozSdraft-jszSsrc.log Monitor logs will go to /private/tmp/flow/zSUserszSprocidaczSDevelopmentzSghzSclaudioprozSdraft-jszSsrc.monitor_log No errors! ``` Pull Request resolved: facebookarchive#1989 Reviewed By: pakoito Differential Revision: D13917267 Pulled By: pakoito fbshipit-source-id: ce66ee4c67c4e7cc46c51ca91a4ade3d980fdf2e
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this pull request
Jul 4, 2023
Summary: **Summary** Fixes a CI build error (#1988) by adding a `$FlowExpectedError` annotation, and upgrading [flow-bin](https://www.npmjs.com/package/flow-bin) to 0.91.0 **Test Plan** ``` yarn run flow flow src ``` ``` → flow src The flow server's version didn't match the client's, so it exited. Going to launch a new one. Launching Flow server for /Users/procidac/Development/gh/claudiopro/draft-js/src Spawned flow server (pid=87525) Logs will go to /private/tmp/flow/zSUserszSprocidaczSDevelopmentzSghzSclaudioprozSdraft-jszSsrc.log Monitor logs will go to /private/tmp/flow/zSUserszSprocidaczSDevelopmentzSghzSclaudioprozSdraft-jszSsrc.monitor_log No errors! ``` Pull Request resolved: facebookarchive/draft-js#1989 Reviewed By: pakoito Differential Revision: D13917267 Pulled By: pakoito fbshipit-source-id: ce66ee4c67c4e7cc46c51ca91a4ade3d980fdf2e
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a CI build error (#1988) by adding a
$FlowExpectedErrorannotation, and upgrading flow-bin to 0.91.0Test Plan
Output: