Opt-Space no longer scrolls (Chrome OSX)

[brookslyrette]

Option + Space no longer causes scrolling. This was only happening in Chrome/OSX. This was happening in the keyDown handler not the keyPress handler.

I'm not sure if I like adding the ' ' to the editor in editOnKeyDown. Maybe I should implement this as a command?

Fixes #19

[hellendag]

The correct EditorChangeType here is 'insert-characters'. (I need to document this, but one should always stick to the EditorChangeType values for push calls.)

[hellendag]

@brookslyrette on the import I ran for your last PR, our bot pulled in changes that had already been merged, I assume because the commits were still present in this stack. Can those older changes be rebased out of this PR?

Regarding the PR itself, I'm wondering if this should be handled within getDefaultKeyBinding. It would be functionally the same as handling it in editOnKeyDown, but at least it would be with other key bindings that check OS/browser combinations.

[brookslyrette]

Thanks @hellendag. I'll make the corrections and rebase the PR.

I had attempted to prevent the scrolling in getDefaultKeyBinding but since I was editing the editorState I placed it in editOnKeyDown. From what I can tell, I can't add the space to the editor state from getDefaultKeyBinding without creating a command.

I'm happy to do so if you think it's a cleaner approach. What name would be appropriate for the command?

[hellendag]

Oh of course, that's a great point. There would have to be a command string for it. Let's stick with what you have.

Were you able to determine what's actually causing this? I.e. why would Draft behave differently from a plain contenteditable?

[brookslyrette]

 As far as I can tell it is because document.activeElement is not the contentEditable area. It's that the div is focused:

That seemed a bit too fundamental for me to be messing around with.

[hellendag]

Hmm, though that div is the contenteditable.

That seemed a bit too fundamental for me to be messing around with.

No worries, I'll see if I can track it down. :)

[brookslyrette]

Just a hunch. This only seems to happen when Option + Space is entered into an empty editor.

Not sure if it's a redraw or the placeholder causing it but I'm sure it has to do with the initial state.

[hellendag]

It happens whenever we have to preventDefault on the textInput event, i.e. when we need to render the character manually rather than allowing the native behavior. This will happen at the start of a paragraph, after an immutable entity, and other cases.

It seems that if the textInput event is prevented when the keydown is allowed, the scroll behavior occurs.

Since we need to prevent the textInput event in the case described above, I think we don't really have any choice but to prevent the keydown and perform the manual insertion as you've done here.

[hellendag]

Repro: https://jsfiddle.net/hellendag/amLxv1w8/

[hellendag]

Is this the correct character to insert here, if the goal of Opt+Space is to insert a non-breaking space? Or should this be '\u00a0'?

[hellendag]

Thanks!

[hellendag]

@facebook-github-bot import

[facebook-github-bot]

Thanks for importing. If you are an FB employee go to Phabricator to review.