This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
fix(security): Upgrades Docusaurus to address CVE-2020-7662 #2457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@claudiopro has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@claudiopro merged this pull request in a08a8fa. |
vilemj-Viclick
pushed a commit
to kontent-ai/draft-js
that referenced
this pull request
Jul 16, 2020
…archive#2457) Summary: **Summary** Upgrades Docusaurus and its dependencies to address [CVE-2020-7662](https://nvd.nist.gov/vuln/detail/CVE-2020-7662) affecting the [websocket-extensions](https://npm.im/websocket-extensions) dependency of the website package. Note I upgraded to `docusaurus/core@^2.0.0-alpha.48` because upgrading with `yarn upgrade` alone revealed the issue described by facebook/docusaurus#2385 and fixed in `v2.0.0-alpha.48`. **Test Plan** ``` # procidac at <redacted>.thefacebook.com in ~/dev/gh/claudiopro/draft-js/website on git:fix-cve-2020-7662 ● [21:21:54] → yarn why websocket-extensions Using globally installed version of Yarn yarn why v1.12.1 warning package.json: No license field [1/4] � Why do we have the module "websocket-extensions"...? [2/4] 🚚 Initialising dependency graph... warning No license field [3/4] 🔍 Finding dependency... [4/4] 🚡 Calculating file sizes... => Found "websocket-extensions@0.1.4" info Reasons this module exists - "websocket-driver" depends on it - Hoisted from "websocket-driver#websocket-extensions" - Hoisted from "docusaurus#core#webpack-dev-server#sockjs#websocket-driver#websocket-extensions" info Disk size without dependencies: "96KB" info Disk size with unique dependencies: "96KB" info Disk size with transitive dependencies: "96KB" info Number of shared dependencies: 0 ✨ Done in 0.66s. # procidac at <redacted>.thefacebook.com in ~/dev/gh/claudiopro/draft-js/website on git:fix-cve-2020-7662 ● [21:23:59] → yarn start ``` Website launches and looks functional: <img width="1392" alt="Screen Shot 2020-06-05 at 9 22 01 PM" src="https://user-images.githubusercontent.com/860099/83919726-21e5b000-a773-11ea-8a36-4e390757f319.png"> Pull Request resolved: facebookarchive#2457 Reviewed By: mrkev Differential Revision: D21911260 Pulled By: claudiopro fbshipit-source-id: 17392a0596b1f6ffc6db184980313d5dab1bea26
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this pull request
Jul 4, 2023
Summary: **Summary** Upgrades Docusaurus and its dependencies to address [CVE-2020-7662](https://nvd.nist.gov/vuln/detail/CVE-2020-7662) affecting the [websocket-extensions](https://npm.im/websocket-extensions) dependency of the website package. Note I upgraded to `docusaurus/core@^2.0.0-alpha.48` because upgrading with `yarn upgrade` alone revealed the issue described by facebook/docusaurus#2385 and fixed in `v2.0.0-alpha.48`. **Test Plan** ``` # procidac at <redacted>.thefacebook.com in ~/dev/gh/claudiopro/draft-js/website on git:fix-cve-2020-7662 ● [21:21:54] → yarn why websocket-extensions Using globally installed version of Yarn yarn why v1.12.1 warning package.json: No license field [1/4] � Why do we have the module "websocket-extensions"...? [2/4] 🚚 Initialising dependency graph... warning No license field [3/4] 🔍 Finding dependency... [4/4] 🚡 Calculating file sizes... => Found "websocket-extensions@0.1.4" info Reasons this module exists - "websocket-driver" depends on it - Hoisted from "websocket-driver#websocket-extensions" - Hoisted from "docusaurus#core#webpack-dev-server#sockjs#websocket-driver#websocket-extensions" info Disk size without dependencies: "96KB" info Disk size with unique dependencies: "96KB" info Disk size with transitive dependencies: "96KB" info Number of shared dependencies: 0 ✨ Done in 0.66s. # procidac at <redacted>.thefacebook.com in ~/dev/gh/claudiopro/draft-js/website on git:fix-cve-2020-7662 ● [21:23:59] → yarn start ``` Website launches and looks functional: <img width="1392" alt="Screen Shot 2020-06-05 at 9 22 01 PM" src="https://user-images.githubusercontent.com/860099/83919726-21e5b000-a773-11ea-8a36-4e390757f319.png"> Pull Request resolved: facebookarchive/draft-js#2457 Reviewed By: mrkev Differential Revision: D21911260 Pulled By: claudiopro fbshipit-source-id: 17392a0596b1f6ffc6db184980313d5dab1bea26
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades Docusaurus and its dependencies to address CVE-2020-7662 affecting the websocket-extensions dependency of the website package.
Note I upgraded to
@docusaurus/core@^2.0.0-alpha.48because upgrading withyarn upgradealone revealed the issue described by facebook/docusaurus#2385 and fixed inv2.0.0-alpha.48.Test Plan
Website launches and looks functional: