Remove NYI warning for readonly hardware watchpoints

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Blame Revision:

Sources/Core/HardwareBreakpointManager.cpp

@@ -29,11 +29,9 @@ ErrorCode HardwareBreakpointManager::add(Address const &address, Type type,
     return kErrorInvalidArgument;
   }
 
-  if (mode == kModeRead) {
-    DS2LOG(Warning,
-           "read-only watchpoints are unsupported, setting as read-write");
-    mode = static_cast<Mode>(mode | kModeWrite);
-  }
+  // Readonly hardware watchpoints aren't natively implemented, so they
+  // are implemened in software instead. See #510
+  if (mode == kModeRead) mode = static_cast<Mode>(mode | kModeWrite);
 
   return super::add(address, type, size, mode);
 }

Sources/Core/X86/HardwareBreakpointManager.cpp

@@ -137,6 +137,9 @@ ErrorCode HardwareBreakpointManager::enableDebugCtrlReg(uint64_t &ctrlReg,
     EnableBit(ctrlReg, infoIdx);
     DisableBit(ctrlReg, infoIdx + 1);
     break;
+  // Readonly watchpoints aren't implemented in hardware, so a
+  // read|write watchpoint is placed, and write halts are filtered
+  // out in software. See #510
   case kModeRead:
   case kModeRead | kModeWrite:
     EnableBit(ctrlReg, infoIdx);