This repository has been archived by the owner on Jan 13, 2022. It is now read-only.
XJS -> JSX #85
Merged
XJS -> JSX #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,6 +1,6 @@ | |||
| /* | |||
| * WARNING: This file is autogenerated by tools/generate-fbtest.js | |||
| * Do NOT modify this file directly! Instead, add your tests to | |||
| * Do NOT modify this file directly! Instead, add your tests to | |||
|
See #86 (comment) for why this is failing in node 0.11 |
|
woohoo! |
|
What changed in |
|
I guess it's also worth to mention @benjamn so he could update ast-types defs as well. |
|
The only issue right now is that it's failing the Travis build |
|
Which is a cascading issue - we need to fix #87 so we can merge upstream in again more cleanly, which updates the linting process, which makes the travis build pass. |
Simple find+replace across the codebase.
|
Rebased and tests passing. We'll want to get our JSX transform in React changed (which is annoying with dependencies and having it in multiple places...). But otherwise, I think we can this in any time. |
lencioni
added a commit
to lencioni/espree
that referenced
this pull request
Mar 7, 2015
The Esprima-FB project recently renamed all references of `XJS` to `JSX`, so this should no longer be listed as an incompatibility. - https://github.com/facebook/esprima/issues/83 - facebookarchive/esprima#85
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple find+replace across the codebase. Tests pass. We'll want to bump major versions for this, but otherwise it seems pretty ok.
Fixes #83
cc @jeffmo @spicyj @sebmarkbage @gabelevi