Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

Fix: Configure whitelist filter for coverage generation #104

Merged
merged 1 commit into from May 16, 2016

Conversation

localheinz
Copy link
Contributor

This PR

  • configures a whitelist filter for generating code coverage

馃拋 Without the filter, phpunit complains:

$ vendor/bin/phpunit --coverage-text
PHPUnit 4.8.24 by Sebastian Bergmann and contributors.
Warning:    No whitelist configured for code coverage

...............................................................  63 / 216 ( 29%)
............................................................... 126 / 216 ( 58%)
............................................................... 189 / 216 ( 87%)
...........................

Time: 9.07 seconds, Memory: 26.75Mb

OK (216 tests, 248 assertions)

@localheinz
Copy link
Contributor Author

@everton-rosario @simonengelhardt

What do you think about using http://codeclimate.com, for example? It's quite useful for tracking coverage, as well as other issues related to the code.

@ghost ghost added the CLA Signed label May 12, 2016
@simonengelhardt
Copy link
Contributor

@localheinz I think that's a great idea. I had considered setting up scrutinizer (since that's used in the main Facebook PHP SDK), but Code Climate seems like an even better option. I'll go ahead and set it up 馃憤

@localheinz
Copy link
Contributor Author

@everton-rosario
Copy link
Contributor

@simonengelhardt @localheinz
Is this PR going to be used?

@localheinz
Copy link
Contributor Author

@everton-rosario

I think it only needs to be merged, right?

@everton-rosario everton-rosario merged commit d7afd7a into facebookarchive:master May 16, 2016
@localheinz localheinz deleted the fix/whitelist branch May 16, 2016 14:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants