This repository has been archived by the owner on Apr 20, 2023. It is now read-only.
Handles <img> tag inside <p> and other tags #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
| use Facebook\InstantArticles\Elements\InstantArticle; | ||
| use Facebook\InstantArticles\Transformer\Warnings\InvalidSelector; | ||
|
|
||
| class ImageRuleParagraph extends ConfigurationSelectorRule |
There was a problem hiding this comment.
I think the naming standard is that all rule classes ends with Rule. What about ImageInsideTextContainerRule?
…n rule that needs to ignore emptness on validation warning messages
| $instant_article = $transformer->getInstantArticle(); | ||
| if ($instant_article) { | ||
| $instant_article->addChild($image); | ||
| //$context->enableIgnoreEmpty(); |
| @@ -86,4 +88,30 @@ protected function emptyElement($document) | |||
| $fragment->appendChild($document->createTextNode('')); | |||
| return $fragment; | |||
| } | |||
|
|
|||
| /** | |||
| * Method that returns the status of ignoring empty for this Element. | |||
There was a problem hiding this comment.
Please comment what this actually do: "Suppress the empty tag warning on validation".
Applied new method names
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Fixes #91 and #92