Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

Added support to more php versions #333

Merged
merged 1 commit into from Nov 9, 2018
Merged

Added support to more php versions #333

merged 1 commit into from Nov 9, 2018

Conversation

everton-rosario
Copy link
Contributor

This PR

  • Adds support to more PHP versions
  • Fixes small glitches into future versions of css-selector

Fixes #332

@facebook-github-bot
Copy link

Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours has expired.

Before we can review or merge your code, we need you to email cla@fb.com with your details so we can update your status.

@takeit
Copy link

takeit commented Oct 3, 2018

what's the status of this? Can it be merged?

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Contributor

@mburak mburak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pestevez pestevez merged commit b7e670c into master Nov 9, 2018
@pestevez pestevez deleted the more_php_versions branch November 9, 2018 18:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants