Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

Empty checker Validator #71

Merged
merged 41 commits into from
May 12, 2016
Merged

Empty checker Validator #71

merged 41 commits into from
May 12, 2016

Commits on Apr 19, 2016

  1. Removed debug lines

    @everton-rosario
    everton-rosario committed Apr 19, 2016
    Configuration menu
    Copy the full SHA
    9d2c316 View commit details
    Browse the repository at this point in the history

  2. Adds a validation for empty TextContainer tags

    @everton-rosario
    everton-rosario committed Apr 19, 2016
    Configuration menu
    Copy the full SHA
    a8aa35c View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2016

  1. Adds call to ->isValid() to all toDOMElement() methods. If not valid,… 

    … wont include the element to the output
    @everton-rosario
    everton-rosario committed Apr 20, 2016
    Configuration menu
    Copy the full SHA
    5d2e6a2 View commit details
    Browse the repository at this point in the history

  2. Added validation to all required fields that should be filled among a… 

    …ll Element object tree structure
    @everton-rosario
    everton-rosario committed Apr 20, 2016
    Configuration menu
    Copy the full SHA
    cc5bfa2 View commit details
    Browse the repository at this point in the history

  3. fix conflict

    @everton-rosario
    everton-rosario committed Apr 20, 2016
    Configuration menu
    Copy the full SHA
    ae55a8a View commit details
    Browse the repository at this point in the history

Commits on May 3, 2016

  1. Conflict fix

    @everton-rosario
    everton-rosario committed May 3, 2016
    Configuration menu
    Copy the full SHA
    3856f18 View commit details
    Browse the repository at this point in the history

  2. PHPCBF fixes

    @everton-rosario
    everton-rosario committed May 3, 2016
    Configuration menu
    Copy the full SHA
    49a1382 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2016

  1. Starting validator and TDD. WIP

    @everton-rosario
    everton-rosario committed May 5, 2016
    Configuration menu
    Copy the full SHA
    fbf5415 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2016

  1. Merge conflict solved

    @everton-rosario
    everton-rosario committed May 9, 2016
    Configuration menu
    Copy the full SHA
    bcb83ff View commit details
    Browse the repository at this point in the history

  2. Validator for empty Footer object

    @everton-rosario
    everton-rosario committed May 9, 2016
    Configuration menu
    Copy the full SHA
    f4a3f8f View commit details
    Browse the repository at this point in the history

  3. Validator for empty Footer object

    @everton-rosario
    everton-rosario committed May 9, 2016
    Configuration menu
    Copy the full SHA
    dbefc5a View commit details
    Browse the repository at this point in the history

  4. Added validation to H3 element

    @everton-rosario
    everton-rosario committed May 9, 2016
    Configuration menu
    Copy the full SHA
    11ecf5b View commit details
    Browse the repository at this point in the history

  5. Added validation to Header element

    @everton-rosario
    everton-rosario committed May 9, 2016
    Configuration menu
    Copy the full SHA
    6655bd3 View commit details
    Browse the repository at this point in the history

  6. Added validation to H3 element

    @everton-rosario
    everton-rosario committed May 9, 2016
    Configuration menu
    Copy the full SHA
    8ec4d90 View commit details
    Browse the repository at this point in the history

  7. Added empty tests to all elements

    @everton-rosario
    everton-rosario committed May 9, 2016
    Configuration menu
    Copy the full SHA
    3eac9ff View commit details
    Browse the repository at this point in the history

Commits on May 10, 2016

  1. Added getChildren() methods to all Container elements. Container Elem… 

    …ent is an Element that can contain other Elements. With this interface is possible to navigate the full tree and check the isValid() items.
    @everton-rosario
    everton-rosario committed May 10, 2016
    Configuration menu
    Copy the full SHA
    96409f7 View commit details
    Browse the repository at this point in the history

  2. Refactored to getContainerChildren() so it wont conflict with getChil… 

    …dren() methods that were previously created
    @everton-rosario
    everton-rosario committed May 10, 2016
    Configuration menu
    Copy the full SHA
    239429e View commit details
    Browse the repository at this point in the history

  3. PHPCBF code style fix

    @everton-rosario
    everton-rosario committed May 10, 2016
    Configuration menu
    Copy the full SHA
    27d07fa View commit details
    Browse the repository at this point in the history

Commits on May 11, 2016

  1. Fixed doc link

    @everton-rosario
    everton-rosario committed May 11, 2016
    Configuration menu
    Copy the full SHA
    6b03f3a View commit details
    Browse the repository at this point in the history

  2. Added getClassName() method to classes who implements Container inter… 

    …face for polimorfic OO
    @everton-rosario
    everton-rosario committed May 11, 2016
    Configuration menu
    Copy the full SHA
    782a26e View commit details
    Browse the repository at this point in the history

  3. Punctuation on comments

    @everton-rosario
    everton-rosario committed May 11, 2016
    Configuration menu
    Copy the full SHA
    cbd0d76 View commit details
    Browse the repository at this point in the history

  4. Fixed code to use the correct instance () to access inner properties

    @everton-rosario
    everton-rosario committed May 11, 2016
    Configuration menu
    Copy the full SHA
    a7f03d6 View commit details
    Browse the repository at this point in the history

  5. Created auxiliary method stringify() to stringify any object like var… 

    …_dump
    @everton-rosario
    everton-rosario committed May 11, 2016
    Configuration menu
    Copy the full SHA
    5f2f770 View commit details
    Browse the repository at this point in the history

  6. Final fixes for InstantArticleValidator and its test unit

    @everton-rosario
    everton-rosario committed May 11, 2016
    Configuration menu
    Copy the full SHA
    966f695 View commit details
    Browse the repository at this point in the history

  7. Finished Validator for InstantArticle and also added a message bundle… 

    … for the warnings during validation
    @everton-rosario
    everton-rosario committed May 11, 2016
    Configuration menu
    Copy the full SHA
    ed25a22 View commit details
    Browse the repository at this point in the history

  8. Diego's comment: https://github.com/facebook/facebook-instant-article… 

    …s-sdk-php/pull/71/files#r62915394
    @everton-rosario
    everton-rosario committed May 11, 2016
    Configuration menu
    Copy the full SHA
    ba4bc0b View commit details
    Browse the repository at this point in the history

  9. Diego's comment: https://github.com/facebook/facebook-instant-article… 

    …s-sdk-php/pull/71/files#r62915610
    @everton-rosario
    everton-rosario committed May 11, 2016
    Configuration menu
    Copy the full SHA
    c4c4fec View commit details
    Browse the repository at this point in the history

  10. Diego's comment: https://github.com/facebook/facebook-instant-article… 

    …s-sdk-php/pull/71/files#r62915981
    @everton-rosario
    everton-rosario committed May 11, 2016
    Configuration menu
    Copy the full SHA
    94f9925 View commit details
    Browse the repository at this point in the history

  11. @see position fixed.

    @everton-rosario
    everton-rosario committed May 11, 2016
    Configuration menu
    Copy the full SHA
    3aa603b View commit details
    Browse the repository at this point in the history

  12. Fixes #71 (comment)

    @everton-rosario
    everton-rosario committed May 11, 2016
    Configuration menu
    Copy the full SHA
    6d93ad8 View commit details
    Browse the repository at this point in the history

  13. At least one item valid will make container valid. Fixes: #71 (comment)… 

    … and #71 (diff)
    @everton-rosario
    everton-rosario committed May 11, 2016
    Configuration menu
    Copy the full SHA
    430e482 View commit details
    Browse the repository at this point in the history

  14. Fixes: #71 (comment)

    @everton-rosario
    everton-rosario committed May 11, 2016
    Configuration menu
    Copy the full SHA
    ca36058 View commit details
    Browse the repository at this point in the history

  15. fixes: #71 (comment)

    @everton-rosario
    everton-rosario committed May 11, 2016
    Configuration menu
    Copy the full SHA
    2417801 View commit details
    Browse the repository at this point in the history

  16. Fixes: #71 (comment)

    @everton-rosario
    everton-rosario committed May 11, 2016
    Configuration menu
    Copy the full SHA
    6d52a3a View commit details
    Browse the repository at this point in the history

  17. Fixes broken tests

    @everton-rosario
    everton-rosario committed May 11, 2016
    Configuration menu
    Copy the full SHA
    c2c4f36 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2016

  1. fix typo

    @everton-rosario
    everton-rosario committed May 12, 2016
    Configuration menu
    Copy the full SHA
    421f398 View commit details
    Browse the repository at this point in the history

  2. Enforces type of to be string[] or Paragraph[] in case the parameter … 

    …is an array
    @everton-rosario
    everton-rosario committed May 12, 2016
    Configuration menu
    Copy the full SHA
    3a59679 View commit details
    Browse the repository at this point in the history

  3. PHPCBF fix

    @everton-rosario
    everton-rosario committed May 12, 2016
    Configuration menu
    Copy the full SHA
    0d54f47 View commit details
    Browse the repository at this point in the history

  4. Added call to add the warnings to the Transformer

    @everton-rosario
    everton-rosario committed May 12, 2016
    Configuration menu
    Copy the full SHA
    bc81e97 View commit details
    Browse the repository at this point in the history

  5. Grammatical changes

    @demoive
    demoive committed May 12, 2016
    Configuration menu
    Copy the full SHA
    8284f82 View commit details
    Browse the repository at this point in the history

  6. Fix test breaking after review of messages

    @everton-rosario
    everton-rosario committed May 12, 2016
    Configuration menu
    Copy the full SHA
    322c59a View commit details
    Browse the repository at this point in the history